Skip to content

Conversation

dprotaso
Copy link
Member

I don't want to advertise qpoptions in the docs. It's really an implementation detail for security guard at this point.

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 15, 2025
@dprotaso dprotaso changed the title Don't advertise qpoption Don't advertise qpoption in developer docs Sep 15, 2025
@knative-prow knative-prow bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 15, 2025
@netlify
Copy link

netlify bot commented Sep 15, 2025

Deploy Preview for knative ready!

Name Link
🔨 Latest commit ba22604
🔍 Latest deploy log https://app.netlify.com/projects/knative/deploys/68f7fc232599c900082d43da
😎 Deploy Preview https://deploy-preview-6372--knative.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@dprotaso
Copy link
Member Author

/assign @evankanderson @davidhadas

@dprotaso
Copy link
Member Author

/cherry-pick release-1.19

@knative-prow-robot
Copy link
Contributor

@dprotaso: once the present PR merges, I will cherry-pick it on top of release-1.19 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 15, 2025
Copy link
Member

@evankanderson evankanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold

I'll give David a day or two to weigh in.

@knative-prow knative-prow bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. labels Sep 15, 2025
@knative-prow knative-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 15, 2025
@davidhadas
Copy link
Contributor

What is the benefit for the community in not publishing this extendibility?
I can understand why if such publication was not available you would not spend the effort to publish it, but remove documentation when it is already there?

@dprotaso
Copy link
Member Author

What is the benefit for the community in not publishing this extendibility?

It's only being used by security guard at the moment.

In the future I'd like to revisit how this mechanic works (eg. I like how envoy gateway patches work) but having it on the website will make that harder to do. eg. I'm expecting an influx of traffic from our graduation announcement.

@davidhadas
Copy link
Contributor

This does not make much sense to me.

Either we are expecting an influx of traffic from our graduation announcement. In which case we may see renewed interest in the project, including in its various features such as security guard. If indeed graduation will result in teams adopting knative to production projects, they may find security features such as security guard extremely helpful.

Or that we expect a continued decline in interest in which case I can understand why we would start decreasing the project as a whole and archive parts which are not core - very possibly including security guard.

In both cases, I would suggest to wait till we see which of the two options occur to decide if it is justified to narrow the project scope and remove its features and documentation related to such features.

@dprotaso
Copy link
Member Author

dprotaso commented Sep 16, 2025

You're conflating security-guard with qpoptions.

I'm saying I want to revisit the mechanic of how qpoptions works thus I don't want people to write new extensions using it.

@davidhadas
Copy link
Contributor

davidhadas commented Sep 16, 2025

Of course we have full control over people writing new extensions using it, as such extensions would be evaluated by the community and suspended based on a new plan to do the extendability, rather than approved in serving.

We can add a sentence to the documentation to state that a new extendability feature is planned and no further use of this extendability is presently expected.

At the same time removing it will result in making it hard for people to follow how the extension presently used by security guard works. I am quite sure that security guard docs also link to these pages and rely on their content. We could with some effort clean all such references and ensure to copy the data to the security guard docs such that it will not appear in serving (although reffering to serving configs). I again suggest that this is not a productive move at this point in time, but if you insist on removing it, I would think it is wise to move it (with some rephrasing) rather than to remove it.

@evankanderson
Copy link
Member

Sorry about the merge -- in #6398 , I moved all the versioned documentation under versioned, to separate it from the blog, testimonials, community pages that are not version-specific. You should be able to just move these files to the new location; I didn't need to change any contents.

@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 23, 2025
@dprotaso dprotaso force-pushed the drop-qpoptions-docs branch from 05d4122 to ba22604 Compare October 21, 2025 21:33
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 21, 2025
@knative-prow knative-prow bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 21, 2025
@dprotaso dprotaso changed the title Don't advertise qpoption in developer docs Advertise qpoption maturity and provide a call to action to inform the maintainers of usage Oct 21, 2025
@dprotaso
Copy link
Member Author

/hold cancel

I change the PR. Instead of removing the content I added an admonition that indicates the alpha maturity and a call to action for those interested to reach out.

If we don't hear from anybody in a few months then that might be a good enough signal.

@knative-prow knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 21, 2025
@evankanderson
Copy link
Member

We looked at download numbers for security-guard, and they are generally <12 for the most recent release from a year ago, but we don't know if other teams or projects might have taken advantage of this hook without mentioning it to us.

Copy link
Member

@evankanderson evankanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 22, 2025
@knative-prow
Copy link

knative-prow bot commented Oct 22, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, evankanderson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 8621cd6 into knative:main Oct 22, 2025
19 checks passed
@knative-prow-robot
Copy link
Contributor

@dprotaso: new pull request created: #6469

In response to this:

/cherry-pick release-1.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants